ld warning on OSX 10.14

Running “make” in the src directory produces the following warning on OSX:

ld: warning: No version-min specified on command line

The shared library is still created, but that warning msg bothered me.

I made the following change to the Makefile eliminate the warning:

stergios ~/src/RedisTimeSeries/src$ git diff Makefile

diff --git a/src/Makefile b/src/Makefile

index ff5f4c3…99b41a4 100644

— a/src/Makefile

+++ b/src/Makefile

@@ -21,7 +21,7 @@ ifeq ($(uname_S),Linux)

    SHOBJ_LDFLAGS ?= -shared -Bsymbolic


    SHOBJ_CFLAGS ?= -dynamic -fno-common -g -ggdb
  •   SHOBJ_LDFLAGS ?= -bundle -undefined dynamic_lookup
  •   SHOBJ_LDFLAGS ?= -bundle -undefined dynamic_lookup -macosx_version_min 10.14



Hi Stergios,
Thanks for the feedback, we added the missing flag.